Fix Claude output display, excessive logging, and Windows compatibility #145
+2,191
−350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add cross-platform path handling utilities - Update build scripts to use shx for Windows compatibility - Fix TypeScript ref type issues in input components - Enhance worktree deletion to handle Windows file locks - Make keyboard shortcut display platform-aware (Cmd vs Ctrl) - Fix notification toggle synchronization across components - Add proper settings reload when notification settings change This ensures Crystal works seamlessly on Windows while maintaining full compatibility with macOS and Linux. Fixes notification settings not being properly applied when toggled off.
- Use cross-platform path utilities in AboutDialog, FileEditor, and SessionListItem - Fix TypeScript ref type in useSessionView - Add Windows build configurations to package.json
The ls command doesn't exist on Windows runners, causing builds to fail. Added 'shell: bash' to ensure the command runs in Git Bash.
This workflow runs on push to our branch without needing approval, allowing us to debug Windows build issues iteratively.
- Add @homebridge/node-pty-prebuilt-multiarch to electron:rebuild command - Ensures node-pty is rebuilt for correct Electron version in CI builds - Fixes issue where terminal sessions weren't properly closed on Windows - This was causing directory locks that prevented worktree removal
…vainian/crystal into windows-compatibility-clean
- Add comprehensive Windows worktree management tests - Fix electron:rebuild to include node-pty for Windows CI builds - Add test:windows npm script for easy test execution - Add PowerShell script for testing Windows binaries - Update CLAUDE.md with file deletion syntax reference This fixes the issue where CI-built Windows binaries couldn't delete worktrees due to node-pty not being rebuilt for the correct Electron version.
- Removed shell wrapper that was causing command prompt pollution - Added filtering for MCP commands that still appear in output - Fixed line break formatting in grouped messages - Removed non-printable characters causing box display
- Removed debug console.log statements - Simplified MCP command filtering to single regex pattern - Kept message grouping and echo filtering as they're needed
…e root The issue was that Crystal was trying to write temporary commit message files to .git/FILENAME, but in git worktrees, .git is a file (not a directory) that contains a pointer to the actual git directory. Changes: - commitManager.ts: Write COMMIT_MSG_TEMP to worktree root instead of .git/ - worktreeManager.ts: Write SQUASH_MSG to worktree root instead of .git/ This fixes the ENOENT error when Crystal tries to create commits in worktrees.
- Add debug mode toggle separate from verbose logging - Create DebugContext for component-level debug control - Replace console.log with conditional debugLog function - Fix main process log forwarding to respect verbose setting - Fix Windows 11 wmic deprecated command using PowerShell fallback - Fix Windows test setup replacing Unix touch command with fs.writeFileSync - Add .grok/ to .gitignore - Significantly reduce console output for better debugging experience Fixes issues with excessive logging that made debugging difficult. Also resolves Windows-specific compatibility problems in tests and worktree management.
Sallvainian
requested review from
SaucyWrong,
ghinkle and
jordan-BAIC
as code owners
Resolved conflicts: - .github/workflows/build.yml: Kept both Windows build config and Linux yml file - package.json: Kept both Windows release script and canary build scripts
Can...
Collaborator
|
Question: The file Edit: Claude wrote this comment, I have already removed it |
This reverts commit 16eb0fe.
This file was accidentally added in PR stravu#145. It appears to be a backup or merge artifact that was committed by mistake. The actual component lives at frontend/src/components/session/RichOutputView.tsx. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Author
|
Sorry :D. Claude can be very dumb sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses three critical issues:
Changes
Claude Output Display Fix (Windows)
Logging Improvements
Windows Compatibility Fixes
Testing
Type of Change
Checklist
Notes