[SPIR-V] Normalize inline SPIR-V for builtins #7974
+426
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, non-static global variables with a inline SPIR-V ext_storage_class attribute were added to the default constant buffer global struct. This is an issue as the point of a custom storage class is to create globals such as acceleration structures. Fixes microsoft#7742
Inline SPIR-V provides mutliple attributes with overlapping capabilities: - vk::builtin - vk::ext_input_builtin - vk::ext_output_builtin - vk::storage_class - vk::decorate The issue is that what should be syntactic sugar was not implemented as such: ext_input_builtin should be sugar for decorate + storage_class. This meant codegen has different paths depending on the attributes used, even if they should in the end have the same effect. As expected, those paths have different behaviors, and some are buggy. This commits adds a new step in sema: attribute normalization. The target idea is to `desugar` some attributes into a more basic format, but it requires large changes in CG. As of now, this commits normalizes a bit the attributes in sema, but might lift decoration+storage into ext_input_builtin. Properly doing de-sugar will require additional changes, especially around parameters & builtin through decorations which works only because codegen checks are not complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #7967
Inline SPIR-V provides mutliple attributes with overlapping
capabilities:
The issue is that what should be syntactic sugar was not implemented as
such: ext_input_builtin should be sugar for decorate + storage_class.
This meant codegen has different paths depending on the attributes used,
even if they should in the end have the same effect.
As expected, those paths have different behaviors, and some are buggy.
This commits adds a new step in sema: attribute normalization.
The target idea is to
desugarsome attributes into a more basicformat, but it requires large changes in CG. As of now, this commits
normalizes a bit the attributes in sema, but might lift
decoration+storage into ext_input_builtin.
Properly doing de-sugar will require additional changes, especially
around parameters & builtin through decorations which works only because
codegen checks are not complete.