Use version properties more, implicitly bumping build-helper-maven-plugin for guava-tests.
#8107
+17
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugin` for `guava-tests`. Compare 3c0e704, in which I was too lazy to search for remaining versions. I've now grepped for `'<version>'` and looked for remaining non-property versions. I'd been figuring that I should get around to this, but the impetus for doing it now is that I decided to ask Gemini an open-ended question about what could be improved in our `pom.xml` files, and this was its main recommendation. (It also suggested bumping the value in `requireMavenVersion` (but I might rather rip out that check entirely) and potentially removing the `plexus-io` workaround (but I'm not sure offhand if it's time yet).) RELNOTES=n/a PiperOrigin-RevId: 840494798
copybara-service
bot
force-pushed
the
test_840336247
branch
from
ab6a1a2 to
7e90c9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use version properties more, implicitly bumping
build-helper-maven-pluginforguava-tests.Compare 3c0e704, in which I was too lazy to search for remaining versions. I've now grepped for
'<version>'and looked for remaining non-property versions.I'd been figuring that I should get around to this, but the impetus for doing it now is that I decided to ask Gemini an open-ended question about what could be improved in our
pom.xmlfiles, and this was its main recommendation. (It also suggested bumping the value inrequireMavenVersion(but I might rather rip out that check entirely) and potentially removing theplexus-ioworkaround (but I'm not sure offhand if it's time yet).)RELNOTES=n/a