fix: clang-tidy warnings, pt. 1 #49083
Open
+11
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: use emplace_back instead of push_back
codebytere
approved these changes
Nov 26, 2025
dsanders11
requested changes
Nov 26, 2025
Comment on lines
+236
to
238
| results.emplace_back(content::PermissionResult( | ||
| blink::mojom::PermissionStatus::DENIED, | ||
| content::PermissionStatusSource::UNSPECIFIED)); |
Member
There was a problem hiding this comment.
Suggested change
| results.emplace_back(content::PermissionResult( | |
| blink::mojom::PermissionStatus::DENIED, | |
| content::PermissionStatusSource::UNSPECIFIED)); | |
| results.emplace_back( | |
| blink::mojom::PermissionStatus::DENIED, | |
| content::PermissionStatusSource::UNSPECIFIED); |
IIRC, emplace_back should just take the constructor arguments directly, right?
Comment on lines
+246
to
248
| results.emplace_back(content::PermissionResult( | ||
| blink::mojom::PermissionStatus::GRANTED, | ||
| content::PermissionStatusSource::UNSPECIFIED)); |
Member
There was a problem hiding this comment.
Suggested change
| results.emplace_back(content::PermissionResult( | |
| blink::mojom::PermissionStatus::GRANTED, | |
| content::PermissionStatusSource::UNSPECIFIED)); | |
| results.emplace_back( | |
| blink::mojom::PermissionStatus::GRANTED, | |
| content::PermissionStatusSource::UNSPECIFIED); |
Same comment as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix most of the warnings uncovered by the first run of @dsanders11's WIP clang-tidy GH Action.
This PR fixes the trivial warnings but leaves
google-default-argumentsfor the next PR because I want to sleep on those two first.All reviews welcomed. CC @dsanders11 😸
Checklist
npm testpassesRelease Notes
Notes: none.