feat: srw #1048
Open
feat: srw #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
reviewed
Dec 4, 2025
|
|
||
|
|
||
| # Common tests for both plugins | ||
| def test_set_read_only_true( |
Contributor
There was a problem hiding this comment.
Looks like some of the tests mostly only has the setup in common for the two plugins. Curious if we should just split them into separate test cases.
Author
There was a problem hiding this comment.
Should be separated in the newest version
aws_advanced_python_wrapper/simple_read_write_splitting_plugin.py
Outdated
Show resolved
Hide resolved
|
|
||
| if ( | ||
| url_type == RdsUrlType.RDS_WRITER_CLUSTER | ||
| or self._verify_opened_connection_type == HostRole.WRITER |
Contributor
There was a problem hiding this comment.
Curious about the relationship between the config params srw_verify_initial_connection_type and srw_verify_new_connections. Looks like we only verify initial connection if srw_verify_new_connections is specified, otherwise it is no op. Could we just double check to ensure we make that extra clear via docs
Author
There was a problem hiding this comment.
I've added another note on top of what was already in the docs :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.