Skip to content

Conversation

@melven
Copy link

@melven melven commented Apr 4, 2025

Add support for the json output format of the ruff python checker. Also works for fortitude which is based on ruff (https://github.com/PlasmaFAIR/fortitude)

@bruntib
Copy link
Contributor

bruntib commented Nov 30, 2025

@melven, Thanks for the development, it's great to have a report-converter for ruff.
For some reason the "Tools" test failed, but I can't see the error message. Could you, please, touch the commit (git commit --amend --no-edit) and force push so tests are re-executed? Hopefully this will solve.
Thank you!

@melven
Copy link
Author

melven commented Dec 3, 2025

@melven, Thanks for the development, it's great to have a report-converter for ruff. For some reason the "Tools" test failed, but I can't see the error message. Could you, please, touch the commit (git commit --amend --no-edit) and force push so tests are re-executed? Hopefully this will solve. Thank you!

Hi @bruntib

I rebased onto the current master, let's see if everything works!

@melven
Copy link
Author

melven commented Dec 3, 2025

Ok, this still fails but I don't really understand why. I tried to make the ruff test very similar to the pylint test.

@bruntib
Copy link
Contributor

bruntib commented Dec 3, 2025

@melven Thanks for the rebase. Also, a required test is failing. We could merge this PR when it's fixed. Thank you!

@melven
Copy link
Author

melven commented Dec 3, 2025

Sorry @bruntib

This was a problem with an absolute path in the report file from ruff. I replaced it with a relative path for testing.

@melven
Copy link
Author

melven commented Dec 3, 2025

Hi @bruntib

Now the unit test succeeds. There is one further problem with the GUI but I don't understand the error message or why this is related to my changes...

Copy link
Collaborator

@gulyasgergely902 gulyasgergely902 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work overall with a minor "issue". Even with that I approve the change.

@@ -0,0 +1,3 @@
# copied from pylint, could
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment in unnecessary here. Please remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants