Shuttle Transfer Vote with Zero Votes Defaults to Continue Round

[Programs-The-Station]

About The Pull Request

The previous PR set a simple majority for the transfer vote, preferring to transfer if tied.

If nobody voted though, the shuttle would automatically be called, because of a tie.

This PR makes it so if there are zero votes, the round will continue, because nobody has a strong enough opinion to vote (or they are all caught up in some shenanigans and missed the vote).

Why It's Good For The Game

If people are enjoying the round enough to not vote, the shuttle should not be called.

Testing Photographs and Procedure

Screenshots&Videos

Changelog

🆑
tweak: Transfer shuttle will not be called when there are zero votes in the poll.
/:cl:

[EvilDragonfiend]

Suggested change

	if(!length(choices_by_ckey))
	return CHOICE_CONTINUE //In the event of a tie on zero votes, continue.
	else
	return CHOICE_SHUTTLE //In the event of an even 50/50 split, we prefer to evacuate
	return length(choices_by_ckey) ? CHOICE_SHUTTLE : CHOICE_CONTINUE
	// In the event of an even 50/50 split, we prefer to evacuate. If nobody voted, we continue.

[PowerfulBacon]

Behaviour is important for round cycling. If nobody wants to continue playing then end the round and let a new one come in. I'd be willing to accept this if it always chooses evacuation if there are no living and online players on the station z level.

[EvilDragonfiend]

Behaviour is important for round cycling. If nobody wants to continue playing then end the round and let a new one come in. I'd be willing to accept this if it always chooses evacuation if there are no living and online players on the station z level.

"Nobody voted" doesn't necessarily mean nobody wants to continue playing. Let's say there are 10 players and nobody just voted, then why should it force them to go ahead to next round?

[PowerfulBacon]

Make it only default to choosing to stay if there is at least 1 living person on the station z-level.