regression: right mouse button click stopped working

[ThomasWaldmann]

Issue with right clicks

See there: https://bugzilla.proxmox.com/show_bug.cgi?id=6515

I suspect it is related to #1919 or #1921 and the changed code wasn't tested on macOS safari and firefox.

The left click works, only the right click stopped working.

Workarounds

Maybe only needed for macOS / apple trackpad users?

• don't use noVNC 1.6.0, downgrade to 1.5.0, or
• use chromium, not safari or firefox, or
• do not use "tap to click" and just press hard with both fingers on the trackpad.

[ThomasWaldmann]

@CendioHalim can you have a look, please?

[CendioHalim]

Just tested this on a mac with firefox using a mouse and the touchpad (2-finger tap) and did not see any issues against an Xvnc server.

For good measure, I tested this with Proxmox 8.4.1 as well in a VM, and did not see any issues.

Could you test if you get any mouse events at all when right clicking? E.g using xev or https://unixpapa.com/js/testmouse.html

[CendioHalim]

To clarify, could you test https://unixpapa.com/js/testmouse.html both locally and inside noVNC

[ThomasWaldmann]

Locally on my macbook, using safari (first 2finger tap / right click, then 1finger tap / left click) to access the unixpapa test page:

mousedown   which=3 button=2 buttons=0
contextmenu which=3 button=2 buttons=0

mousedown   which=1 button=0 buttons=0
mouseup     which=1 button=0 buttons=0
click       which=1 button=0 buttons=0

Locally on my macbook, using firefox to access the unixpapa test page:

mousedown   which=3 button=2 buttons=0
contextmenu which=3 button=2 buttons=0
mouseup     which=3 button=2 buttons=0

mousedown   which=1 button=0 buttons=1
mouseup     which=1 button=0 buttons=0
click       which=1 button=0 buttons=0

Locally on my macbook, using chromium to access the unixpapa test page:

mousedown   which=3 button=2 buttons=2
contextmenu which=3 button=2 buttons=2
mouseup     which=3 button=2 buttons=0

mousedown   which=1 button=0 buttons=1
mouseup     which=1 button=0 buttons=0
click       which=1 button=0 buttons=0

[CendioHalim]

Ah, I see the issue. In #1921, we changed from looking at the mousedown event to instead just checking the current state (buttons=0) in your case. I'm guessing left click doesn't work for you either?

Could you clarify if those results were on your local machine, or inside noVNC?

[ThomasWaldmann]

Accessing the Proxmox console (noVNC 1.5.0) from macOS/safari, windows 11 VM with firefox, accessing the test page from within the VM:

mousedown   which=3 button=2 buttons=2
mouseup     which=3 button=2 buttons=0
contextmenu which=3 button=2 buttons=0

mousedown   which=1 button=0 buttons=1
mouseup     which=1 button=0 buttons=0
click       which=1 button=0 buttons=0

[ThomasWaldmann]

Accessing the Proxmox console (noVNC 1.6.0) from macOS/safari, windows 11 VM with firefox, accessing the test page from within the VM:

(nothing)

mousedown   which=1 button=0 buttons=1
mouseup     which=1 button=0 buttons=0
click       which=1 button=0 buttons=0

[ThomasWaldmann]

(added some clarifications to my above posts)

[CendioHalim]

That is very weird.

The local/chromium case looks correct, not sure what this might be.

You don't happen to have some mice-related software installed on your machine? I remember having issues with Logitech's software (Logi Options+ iirc) on a mac which would cause issues.

[ThomasWaldmann]

Well, it works with noVNC 1.5.0 and not with 1.6.0, so the issue is likely there, right?

[CendioHalim]

Between 1.5.0 and 1.6.0, we switched from tracking the current mouse button state manually by looking at mouseup and mousedown events. Now, we simply get the button state directly from the browser. Reverting this change would unfortunately break forward/back mouse support on macOS.

From what you've posted, it looks like the browser is reporting the button state incorrectly (buttons in the mouse tests).

Unfortunately, there is not much we can do in noVNC is the browser is providing us incorrect information.

Tested this on a mac mini and a MB Air M3 and did not see any issues. Are you sure you don't have some mouse software installed on your machine?

[ThomasWaldmann]

I have some utilities installed, but nothing mouse/touchpad specific (e.g. alt-tab, rectangle). Also just using the MBP internal input devices, no external or 3rd party input devices.

Also, if there was something broken due to some sw on my machine, why does it work with chromium then and just not with safari and firefox?

[ThomasWaldmann]

I tried to rule out any influence of other tools running on this machine:

• I revoked all "Privacy and Security" permissions for "input monitoring" and "accessibility".
• I shut down and cold booted the machine.
• Terminated all software that is not essential.

Didn't help, right-clicking with noVNC 1.6.0 is still broken in safari and firefox, while it works with chromium.

[CendioHalim]

Thanks for testing, much appreciated.

Not sure what to do here. I can't reproduce this on my end, and couldn't find any related bug reports in firefox/safari. I'll do some further digging and get back to you.

[ThomasWaldmann]

Found something:

• I usually use "tap to click", so that a soft tap on the trackpad is enough to click. The setting is in Settings -> Trackpad -> Point & Click -> Tap to click -> Enabled.
• Doing it like that, it is broken like I reported above.
• When hard-clicking (pressing the trackpad harder), then left and right clicks work as expected!